Skip to content

Conversation

@dschodits-secunet
Copy link

@dschodits-secunet dschodits-secunet commented Nov 18, 2025

This Pr solves Issue: #22333 by adding Support for UnaryInterceptors in the Java-Native-Client

This is done by adding a new config option called "useUnaryInterceptor" which changes the Datatype of the ResponseInterceptor from a Consumer to a UnaryInterceptor. With a variable reassignment this allows for changing an incomming response before it gets passed.

This change doesn't break any existing Systems due to the default value of false for the "useUnaryInterceptor".

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@dschodits-secunet dschodits-secunet marked this pull request as draft November 19, 2025 10:24
@dschodits-secunet dschodits-secunet marked this pull request as ready for review November 21, 2025 14:00
@dschodits-secunet dschodits-secunet marked this pull request as draft November 21, 2025 14:01
@dschodits-secunet dschodits-secunet marked this pull request as ready for review November 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant